[Webkit-unassigned] [Bug 87548] check-webkit-style cannot running in Chinese windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87548


huangxueqing <huangxueqing at baidu.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182481|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from huangxueqing <huangxueqing at baidu.com>  2013-01-13 02:15:57 PST ---
Created an attachment (id=182481)
 --> (https://bugs.webkit.org/attachment.cgi?id=182481&action=review)
patch

The version info retrieved in Chinese Windows was "Microsoft Windows [版本 6.1.7601]", "版本"('version' in English) was encoded as "0xB0 0xE6 0xB1 0xBE" and '0xB0' was not a valid utf-8 character, thus check-webkit-style running failed.
Actually, we execute "cmd /c ver" then use regular expression to match version infomation, it's unnecessary to decode the output string of execution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.