[Webkit-unassigned] [Bug 74776] Commit queue building & running tests on Chromium shouldn't land JSC or WK2 changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 21:04:03 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=74776


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #22 from Adam Barth <abarth at webkit.org>  2013-01-10 21:05:52 PST ---
> I'm sorry but I don't follow. On one hand, you say that we shouldn't wait for bots and EWS is only advisory. On the other hand, you say that bots should be able to cq- on time to recent commit-queue from landing patches.

There's "should" in that sentence.  That's how the system works today.

> Either EWS is advisory, in which case, it shouldn't be required for commit-queue to the right thing, or it should be a required system for commit-queue to work properly.

That's a false dichotomy.  People are perfectly capable of changing the bot-set commit-queue- into a commit-queue+ if that's the appropriate thing to do.

> If your position is that we can't fix this bug or this bug is invalid, then I'll make an announcement in webkit-dev instead saying that we shouldn't be using commit-queue to land JSC/WK2 specific patches and/or I'll propose to make changes so that cq+ is ignored on JSC/WK specific patches.

My position is that this bug is invalid.  You're welcome to start whatever threads you like on webkit-dev.  However, I don't support that change to how the commit-queue+ flag works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list