[Webkit-unassigned] [Bug 74776] Commit queue building & running tests on Chromium shouldn't land JSC or WK2 changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 15:05:34 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=74776





--- Comment #11 from Rafael Brandao <rafael.lobo at openbossa.org>  2013-01-10 15:07:23 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > At that time, I've figured out the breakage happened because the faulty patch was rolled out manually right before the build fix I've submitted landed via commit-queue, and then the fix would not make any sense. Not sure of how waiting for bots results would help in this case.
> 
> I don't think roll outs need to wait for EWS bots.

Me neither. What happened was an unfortunate and unavoidable set of actions:
1. Patch A lands. Breaks some build system.
2. Patch B is evaluated for EWS to fix build A and it's correct. Waiting to land via commit-queue.
3. Patch C reverts A and it's landed faster (manually or maybe commit-queue prioritization of commits if any).
4. Patch B lands. But without A, it makes no sense and breaks everything.

So the best thing to do (tm) is to just poke the author of patch A and ask it to fix, or just poke on the original bug, rather than creating a separate bug to fix it. I'm still missing how 4th step could be avoided by any heuristic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list