[Webkit-unassigned] [Bug 106539] PDFPlugin: Tab between text annotations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106539





--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2013-01-10 09:00:41 PST ---
(From update of attachment 182089)
View in context: https://bugs.webkit.org/attachment.cgi?id=182089&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:74
> +        PDFPluginTextAnnotation* m_annotation;

So the design is that the pointer can become stale, but it won't be used in that case?

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:137
> +        if (keyboardEvent->keyCode() == VK_TAB) {
> +            if (keyboardEvent->getModifierState("Shift"))

This is not really the right way to check for key combinations. We should let Cocoa decide whether a key combination matches.

It's easy to observe the difference by adding a new combination for insertTab: in DefaultKeyBinding.dict. Also, Cocoa accurately checks all modifiers, so it doesn't steal e.g. Ctrl+Tab.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.