[Webkit-unassigned] [Bug 106553] [V8] Add IDL Enum support WIP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106553





--- Comment #1 from Kentaro Hara <haraken at chromium.org>  2013-01-10 06:07:57 PST ---
(From update of attachment 182112)
View in context: https://bugs.webkit.org/attachment.cgi?id=182112&action=review

Please add a ChangeLog. You can generate a ChangeLog by ./Tools/Scripts/prepare-ChangeLog.

> Source/WebCore/bindings/scripts/CodeGenerator.pm:56
> +my %enumTypeHash = ();  # populated from IDL

WebKit is not likely to add such a non-helpful comment. Ditto for other parts. Please leave helpful comments only.

This patch also contains a lot of debug comments. I'd be happy if you could remove them for review.

> Source/WebCore/bindings/scripts/IDLParser.pm:1
> -# 
> +#

Please do not edit unrelated code. Ditto for other style changes in this patch. Conventionally you are allowed to make style changes when you make some meaningful changes around it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.