[Webkit-unassigned] [Bug 106548] [chromium] move webpermissionclient related methods to TestRunner library
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 10 04:59:19 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106548
--- Comment #3 from jochen at chromium.org 2013-01-10 05:01:11 PST ---
(From update of attachment 182108)
View in context: https://bugs.webkit.org/attachment.cgi?id=182108&action=review
> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:81
> + // the location of the layout test in the file system.
no need to put the comment here
> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:65
> + virtual WebKit::WebPermissionClient* webPermissions() { return 0; }
should be const
> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:35
> +#include "WebTestRunner.h"
not needed?
> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:42
> + : m_delegate(delegate)
just initialize this to 0 instead of passing 0 as parameter
> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:39
> +class WebTestRunner;
not needed?
> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:69
> +
remove empty line here
> Tools/DumpRenderTree/chromium/TestRunner/src/WebPermissions.h:82
> +}
and add one here after the }
> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1085
> + return normalizeLayoutTestURLInternal(url);
instead of copying the code, can you do m_shell->normalizeLayoutTestURL(urL)?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list