[Webkit-unassigned] [Bug 105846] [WK2][EFL] Add guard around NativeWebTouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105846





--- Comment #14 from Seokju Kwon <seokju.kwon at gmail.com>  2013-01-09 22:25:55 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 181876 [details] [details])
> > (In reply to comment #11)
> > > (From update of attachment 181876 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=181876&action=review
> > > 
> > > > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27
> > > > +#if ENABLE(TOUCH_EVENTS)
> > > 
> > > NativeWebTouchEventEfl.cpp already uses this guard. 
> > 
> > You can just move that guard up under the #include of config.h.
> 
> Seokju, please do that. Then, I will set cq+.
> 
> > > I think this build break occurs because NativeWebTouchEvent.h doesn't use the guard. I think it would be good to add this guard to NativeWebTouchEvent.h.
> > 
> > See my previous comments.
> 
> >> With a few exceptions, the feature #ifdef should be on the #include side, not in the header.
> 
> I have no strong opinion on this, but it seems to me #ifdef has been using in header in many places. For example, Modules sub-directories. But, I don't wanna object your opinion.

Ok, Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.