[Webkit-unassigned] [Bug 104600] [Chromium] Always enable autocomplete for password fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104600


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181976|review?                     |review-
               Flag|                            |




--- Comment #50 from Tony Chang <tony at chromium.org>  2013-01-09 14:12:15 PST ---
(From update of attachment 181976)
View in context: https://bugs.webkit.org/attachment.cgi?id=181976&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=104600
> +
> +        Don't check autocomplete in webkit code. Rather, we check it in chrome code in the following way: if the password field is chrome generated password, we ignore autocomplete=off and always fill the password; otherwise, we respect the autocomplete set. Since this is a chrome only feature, we make it configurable (default to false but enable this in chrome code).

Sorry, I mean to remove the WebCore/ChangeLog file.  You still need the "Reviewed by NOBODY (OOPS!)." line so the tools can fill in the actual reviewer.  You can also write "Reviewed by Darin Fisher." since he gave an r+ on an earlier patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.