[Webkit-unassigned] [Bug 102828] r134080 causes heap problem on linux systems where PAGESIZE != 4096

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102828


Mark Hahnenberg <mhahnenberg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181941|review?                     |review-
               Flag|                            |




--- Comment #14 from Mark Hahnenberg <mhahnenberg at apple.com>  2013-01-09 11:34:43 PST ---
(From update of attachment 181941)
View in context: https://bugs.webkit.org/attachment.cgi?id=181941&action=review

> Source/JavaScriptCore/heap/BaseBlock.h:33
> +class BaseBlock {

It seems like major overkill to define an entirely new class whose sole purpose is to make sure a static constant is the same between two classes. Why not just use a COMPILE_ASSERT? And why not just change the value in Options.cpp to be 4 KB rather than pageSize()?

> Source/JavaScriptCore/heap/MarkStack.cpp:-54
> -    ASSERT(MarkStackSegment::blockSize == WeakBlock::blockSize);

Why wasn't this ASSERT firing before if the MarkStackSegment blockSize was not equal to the WeakBlock blockSize?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.