[Webkit-unassigned] [Bug 104384] Web Inspector: Pass the script url to the script-preprocessor script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104384





--- Comment #15 from johnjbarton <johnjbarton at chromium.org>  2013-01-09 10:28:09 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > I think you should land jsc expectations and the main ones and chromium as specific. I.e. as in your patch. It is just that jsc expectations needed tweaking in the places I suggested.
> > 
> > Sorry I don't understand how to do this. I guess 'jsc' is the Safari port? What tweaks are needed, where might they go and how could I test them?
> 
> Comment #9 describes what needs to change. You can only test it using EWS.

What I did not realize is that there are two different ...expected.txt files. The one in comment #9 is apparently the "jsc expectations", and it should reflect the test running without this preprocessor. I suppose then that its content can be predicted simply by disabling the preprocessor and copying the test results.

The other file, 
 LayoutTests/platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt
 is the one that is used when testing chromium and it should contain the preprocessed results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.