[Webkit-unassigned] [Bug 106434] [chromium] move dumpcreateview methods to testrunner library
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 9 07:55:42 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106434
--- Comment #5 from jochen at chromium.org 2013-01-09 07:57:35 PST ---
(From update of attachment 181925)
View in context: https://bugs.webkit.org/attachment.cgi?id=181925&action=review
> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:58
> +class WebURLRequest;
these should be alphabetically sorted. First all classes, then all structs
> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:60
> + virtual bool canOpenWindows() { return false; }
const missing
> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:146
> +static string URLDescription(const GURL& url)
you can remove the static and move it in the anonymous namespace above
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list