[Webkit-unassigned] [Bug 106434] [chromium] move dumpcreateview methods to testrunner library

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 04:04:51 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106434





--- Comment #3 from jochen at chromium.org  2013-01-09 04:06:44 PST ---
(From update of attachment 181886)
View in context: https://bugs.webkit.org/attachment.cgi?id=181886&action=review

I would recommend to move this method together with canOpenWindows, so you can move the first two if statements of WebViewHost::createView to WebTestProxyBase::createView (and add WebTestProxy::createView to invoke it)

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h:169
> +    void dumpCreateView(const CppArgumentList&, CppVariant*);

this should go in the section of methods that modify TestRunner's state (after dumpTitleChanges iirc)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list