[Webkit-unassigned] [Bug 106123] REGRESSION(r138222?): [Mac WK1] http/tests/appcache/main-resource-redirect.html asserts in WebFrameLoaderClient::dispatchDidFinishLoading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106123


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181802|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #20 from Alexey Proskuryakov <ap at webkit.org>  2013-01-08 16:57:02 PST ---
(From update of attachment 181802)
View in context: https://bugs.webkit.org/attachment.cgi?id=181802&action=review

> Source/WebCore/loader/MainResourceLoader.cpp:193
> +        if (resourceLoader)

I asked Nate on IRC, and he doesn't know if this can actually happen in practice. It's very confusing to have unnecessary null checks just in case, but given the urgency, I guess I can grudgingly say r=me.

> Source/WebCore/loader/ResourceLoader.h:143
> +    void setSendCallbackPolicy(SendCallbackPolicy sendLoadCallbacks)  { m_options.sendLoadCallbacks = sendLoadCallbacks; }

Extra space before '{'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.