[Webkit-unassigned] [Bug 106257] [WK2] Set IndexedDB database path in WK2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106257


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181583|review?                     |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2013-01-08 16:54:49 PST ---
(From update of attachment 181583)
View in context: https://bugs.webkit.org/attachment.cgi?id=181583&action=review

What this is doing is basically create a global variable m_indexedDBDatabasePath indirectly through WebProcess, and use that to initialize IndexedDBDatabasePath.

We should probably pass the path down to WebPageGroupProxy instead of making it global(?).

If you really want to make this global, please generalize WebKeyValueStorageManager instead of extending WebProcess (if I am not mistaken, IndexedDB is still a kind of key-value store).

> Source/WebKit2/WebProcess/WebProcess.h:183
> +#if ENABLE(INDEXED_DATABASE)
> +    String indexedDBDatabasePath() const { return m_indexedDBDatabasePath; }
> +#endif

The return type should be const String&.

> Source/WebKit2/WebProcess/WebProcess.h:366
> +#if ENABLE(INDEXED_DATABASE)
> +    String m_indexedDBDatabasePath;
> +#endif

This looks like the wrong place to store something like this, this is what Settings are for.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.