[Webkit-unassigned] [Bug 106123] REGRESSION(r138222?): [Mac WK1] http/tests/appcache/main-resource-redirect.html asserts in WebFrameLoaderClient::dispatchDidFinishLoading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 16:25:28 PST 2013


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #181725|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #16 from Alexey Proskuryakov <ap at webkit.org>  2013-01-08 16:27:22 PST ---
(From update of attachment 181725)
View in context: https://bugs.webkit.org/attachment.cgi?id=181725&action=review

> Source/WebCore/loader/MainResourceLoader.cpp:185
> +        // We need to remove our reference to the CachedResource (which will probably cancel its underlying ResourceLoader)

Why is the cancellation just "probable"? If the load is not canceled now, will it be canceled later, outside the temporary DoNotSendCallbacks mode?

> Source/WebCore/loader/MainResourceLoader.cpp:192
> +        if (resourceLoader)
> +            resourceLoader->setSendCallbackPolicy(DoNotSendCallbacks);
>          clearResource();
> +        resourceLoader->setSendCallbackPolicy(SendCallbacks);

It looks wrong to have a null check the first time we dereference resourceLoader, but not the second time. If it's actually possible to not have a resourceLoader here, please add a regression test for this case.

Also, is this expected to reset policy to original value? Can we assert that SendCallbacks is actually the original value?

> Source/WebCore/ChangeLog:14
> +        (WebCore::ResourceLoader::sendCallbackPolicy): Renamed from shouldSendResourceLoadCallbacks(), returns an enum value instead of a bool.

I'm not sure why this is an improvement. A boolean gives the needed answer more directly, as evidenced by how you had to modify the call site.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list