[Webkit-unassigned] [Bug 105846] Add guard around NativeWebTouchEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 15:50:32 PST 2013


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #181790|review?                     |review-
               Flag|                            |

--- Comment #8 from Benjamin Poulain <benjamin at webkit.org>  2013-01-08 15:52:24 PST ---
(From update of attachment 181790)
View in context: https://bugs.webkit.org/attachment.cgi?id=181790&action=review

> Source/WebKit2/ChangeLog:8
> +        Add TOUCH_EVENTS guard.

Please add a sentence to say this fixes EFL build without TOUCH_EVENTS.

> Source/WebKit2/Shared/qt/NativeWebTouchEventQt.cpp:29
>  #include "NativeWebTouchEvent.h"
> +#endif

This is not correct for Qt.

For performance reason, Qt exclude such files through the project file. In this case, NativeWebTouchEventQt.cpp is excluded from Target.pri if TOUCH_EVENTS is not defined.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list