[Webkit-unassigned] [Bug 103220] [GTK] Build with LevelDB when IndexedDB is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103220


Jussi Kukkonen (jku) <jussi.kukkonen at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.kukkonen at intel.com




--- Comment #6 from Jussi Kukkonen (jku) <jussi.kukkonen at intel.com>  2013-01-08 00:46:35 PST ---
I was just looking at this for EFL...

(In reply to comment #3)
> I think you should explain here why we need to build leveldb in our jhbuild, and why it requires a patch. Do different versions of leveldb give different results of layout tests? would it be possible to run the tests with the leveldb installed by the distro?

You guys maybe handled this in other channels, but for reference:
>From what I've seen so far, the big stumbling block is helpers/memenv/memenv.h which is apparently not considered part of the library, but is used by many leveldb users. Otherwise it looks decent if not aimed at typical shared distribution (Makefile doesn't even have an install target). 

We could just copy-paste the memenv helper (< 380 lines of C++) into webkit and use distro/jhbuild leveldb, right?

> > configure.ac:1030
> > +if test "$enable_indexed_database" = "yes"; then
> > +    PKG_CHECK_MODULES([LEVELDB], [leveldb])
> > +    AC_SUBST([LEVELDB_CFLAGS])
> > +    AC_SUBST([LEVELDB_LIBS])
> > +fi
> 
> This depends on a patch applied to leveldb by our jhbuild which means that it will always fail when not using the internal jhbuild + build-webkit even if leveldb is installed. I think you should use AC_SEARCH_LIBS() when PKG_CHECK_MODULES() fails to find the library.

Is your leveldb patch somewhere available? I was just patching it for testing as well and it would make sense if we were using the same patch...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.