[Webkit-unassigned] [Bug 93832] text-combine falls back to none rather than scale when wider than 1.1em

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93832





--- Comment #37 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2013-01-07 21:01:26 PST ---
(In reply to comment #33)
> After discussing with a few experts, I think this patch needs to revise:
> 1. to remove unused code. Since it always combines, it'd be the right thing to remove m_isCombined = true and also remove where it's false.
> 2. When only some glyphs do support hwid/twid/qwid but some don't, the current patch combines hwid/twid/qwid versions of glyphs and normal glyphs and then scale. This looks poor. The right fix should be to find the thinnest feature where all glyphs support, and then scale if it's still needed.

Fixed.

> Test case should cover #2 (for example, put "#123" where "#" usually doesn't have hwid/twid/qwid).

Hiragino font have width variant glyph of "#".
It also have "\" and "@".
Therefore, I use japanese character.

> Another suggestion is that combine-compress test case is too small to see the result, it'd be better to use larger font size.

I enlarge font and move expectations to comment.

> I'm afraid to say that this means the patch needs to be re-done, sorry about that, but appreciate your understanding.

No problem!
Any suggestions are welcome.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.