[Webkit-unassigned] [Bug 106230] media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 14:20:16 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106230





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2013-01-07 14:22:11 PST ---
(In reply to comment #2)
> I applied your patch from bug 105536 and the test is failing because with the
> patch applied the toggling the captions button has no effect anymore (e.g. a user
> can't disable track rendering). I didn't look yet in the code for the cause.

It fails because clicking the captions button in a port without a captions menu eventually ends up in  HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured, which depends on the code removed from HTMLMediaElement::configureTextTrackGroup by bug 105536 to choose the most appropriate default track.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list