[Webkit-unassigned] [Bug 106034] MediaControls::show() should make controls opaque

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106034





--- Comment #8 from Min Qin <qinmin at chromium.org>  2013-01-04 12:22:40 PST ---
(From update of attachment 181324)
View in context: https://bugs.webkit.org/attachment.cgi?id=181324&action=review

>> Source/WebCore/ChangeLog:9
>> +        If the user exits fullscreen while the timer expires, webkit will call mediaControls::show(). However, show() actually displays nothing as the control is transparent.
> 
> Nit: this line is still twice as long as the others.

fixed

>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:21
>> +        function oncanplaythrough() {
> 
> Nit: a function's opening brace should be on a new line.

fixed

>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:47
>> +                runWithKeyDown(function(){ video.webkitRequestFullscreen(); });
> 
> Nit: a single line if statement doesn't need a brace.

fixed

>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:51
>> +        function onfullscreenchange() {
> 
> Nit: a function's opening brace should be on a new line.

fixed

>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:64
>> +                    }
> 
> Nit: a single line if statement doesn't need a brace.

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.