[Webkit-unassigned] [Bug 106034] MediaControls::show() should make controls opaque
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 10:16:13 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106034
--- Comment #4 from Min Qin <qinmin at chromium.org> 2013-01-04 10:18:12 PST ---
(From update of attachment 181221)
View in context: https://bugs.webkit.org/attachment.cgi?id=181221&action=review
>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:11
>> + var fadeoutTime = 4000;
>
> Four seconds is a very long time for a layout test. Does it need to be this long?
Currently the webkit fullscreen timer is set to 3 seconds to fade out the media control. And we need some time for the fading animation.
I can file a seperate bug later to make this webkit fullscreen timeout value configurable.
>> LayoutTests/media/video-controls-visible-exiting-fullscreen.html:21
>> + var oncanplaythrough = function() {
>
> Nit: It seems strange to have some functions declared as a variable with an anonymous function and some with a function declaration.
Done, changed everything to function declaration.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list