[Webkit-unassigned] [Bug 106081] REGRESSION(r138544): [GTK] Clicking on selected text in a text editable deletes the selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106081





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2013-01-04 08:37:22 PST ---
(From update of attachment 181286)
View in context: https://bugs.webkit.org/attachment.cgi?id=181286&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:626
> -    priv->inputMethodFilter.notifyMouseButtonPress();
> -
>      if (!priv->clickCounter.shouldProcessButtonEvent(buttonEvent))
>          return TRUE;
>  
>      // If it's a right click event save it as a possible context menu event.
>      if (buttonEvent->button == 3)
>          priv->contextMenuEvent.set(gdk_event_copy(reinterpret_cast<GdkEvent*>(buttonEvent)));
> +
> +    priv->inputMethodFilter.notifyMouseButtonPress();

I think either way, it makes sense to cancel the composition. clickCounter.shouldProcessButtonEvent just discards "extra" events that happen during the process of multi-clicking, so the chances of this making a difference are pretty small.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.