[Webkit-unassigned] [Bug 105473] Implement :future pseudo class for the WebVTT ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105473





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2013-01-02 15:00:30 PST ---
(From update of attachment 180558)
View in context: https://bugs.webkit.org/attachment.cgi?id=180558&action=review

> Source/WebCore/html/track/TextTrackCue.h:138
> +    void setNodeObjectFlags(Node *, double, double);

Actually it can be tightened to take Element. Also * placement here.

> Source/WebCore/html/track/TextTrackCue.h:211
> -    RefPtr<HTMLDivElement> m_pastDocumentNodes;
> -    RefPtr<HTMLDivElement> m_futureDocumentNodes;
> +    RefPtr<HTMLDivElement> m_allDocumentNodes;

Name m_allDocumentNodes makes little sense except as a reference that there used to be two separate tree. At least drop "all" and preferably find a better name "m_displayTree"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.