[Webkit-unassigned] [Bug 105508] Proposal: Add fillRule to canvas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105508





--- Comment #19 from Dirk Schulze <krit at webkit.org>  2013-01-02 11:04:12 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > I have also raised this on the webkit-dev at lists.webkit.org mailing list as suggested.
> > 
> > http://lists.webkit.org/pipermail/webkit-dev/2013-January/023209.html
> 
> Great! It's probably best to continue the conversation there.
> I looked at Skia and they make winding part of the fill and clip call.

(In reply to comment #15)
> (In reply to comment #12)
> > Created an attachment (id=180692)
 --> (https://bugs.webkit.org/attachment.cgi?id=180692&action=review) [details] [details]
> > Patch to expose fillRule canvas property
> > 
> > Patch updated to expose the property as fillRule (instead of the prefixed webkitFillRule).  I also tried to fix the failing test, let's see what the buildbot thinks of the change.
> 
> I think this feature needs more discussion.
> Specifically I'd like to not have the winding rule as part of the graphics state. There really is no reason since this is not a feature you want to have in the environment (like strokewidth, color, etc)
> 
> What I'd like to see:
> - make the fill rule flag part of the path syntax
> - have separate eofill/eoclip for clipping/drawing with the current path
> - extend canvas prose so outlines are defined to be unaffected by winding rules.

fillRule is already part of our graphics state. IIRC it is the default behavior on most 2d graphics libraries. IMO it makes most sense to add an fillRule attribute instead of changing the path syntax. And even if we could have clipRule and fillRule as separate attributes, it should not be a big deal to use the same attribute for both operations. Maybe it means that fillRule should be renamed to windingRule.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.