[Webkit-unassigned] [Bug 110612] Enumerating an HTMLCollection needs to enumerate the named properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110612





--- Comment #7 from Arko Saha <arko at motorola.com>  2013-02-28 17:43:53 PST ---
(In reply to comment #5)
> We shouldn't be iterating through nodes like this if we already have a cache (m_idCache and m_nameCache).
> If needed, we should modify the cache structure of HTMLCollection to satisfy this use case.
> 

Will do.

> Please make sure to test other subclasses of HTMLCollection like HTMLAllCollection, HTMLPropertiesCollection, etc...

This patch only fixes HTMLCollection's enumeration. To fix other subclasses of HTMLCollection we need to use CustomGetPropertyNames and change their bindings respectively too.
One approach of this problem may be add a new idl attribute and use it to respective subclass to generate common code automatically. It will allow us to generate common code for all classes and no need to write custom binding.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.