[Webkit-unassigned] [Bug 111097] Chromium: Use Texture Mailboxes to Transport WebGL Buffers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111097





--- Comment #7 from Kenneth Russell <kbr at google.com>  2013-02-28 15:56:05 PST ---
(From update of attachment 190774)
View in context: https://bugs.webkit.org/attachment.cgi?id=190774&action=review

> Source/Platform/chromium/public/WebCompositorSupport.h:84
> +    virtual WebExternalTextureLayer* createExternalTextureLayer(WebExternalTextureLayerClient* = 0, bool mailbox = false) { return 0; }

Minor comment: adding bool arguments to methods makes call sites difficult to read. Either add a descriptive enum, or add another virtual function. I would suggest the latter since it will probably make landing the patch easier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.