[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 14:15:25 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #11 from Manuel Rego Casasnovas <rego at igalia.com>  2013-02-28 14:17:49 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > I guess that the solution should be:
> > 1) Update WK1 code to use Page settings for selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled. I guess it should be done in a generic way and remove the specific  ports code related to selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled.
> > 2) Remove code related to selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled from DRT.
> 
> We should probably do both of these in one patch. It might make sense to do this prior to introducing WK2 bits.

Yes I agree, so first I'd try to provide a patch doing:
* Include the new setting "selectTrailingWhitespaceEnabled" in WebCore::Page.
* Change WK1 code to use the new settings selectTrailingWhitespaceEnabled and smartInsertDeleteEnabled for all the ports that have this already implemented.
* Remove code related to these settings in DRT (reviewing the implementation of the different ports too).
* Change tests to use internals.

Then in a separated patch, I'd add the WK2 bits that were already included in the attached patch.

Thanks for the feedback, I hope to come with something in this line the sooner the better :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list