[Webkit-unassigned] [Bug 110487] Ctrl+Shift+Right in Windows should select the spacing after the word

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110487





--- Comment #30 from Claudio Saavedra <csaavedra at igalia.com>  2013-02-27 23:31:29 PST ---
(In reply to comment #29)
> (From update of attachment 190658 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190658&action=review
> 
> > Source/WebCore/platform/text/TextBoundaries.cpp:65
> > -int findNextWordFromIndex(const UChar* chars, int len, int position, bool forward)
> > +int findNextWordFromIndex(const UChar* chars, int len, int position, bool forward, bool skipSpaces)
> 
> It's not a good idea to modify findNextWordFromIndex like this. Please follow what we did for visualWordPosition.

Thanks for the comments. Not sure I understand though. visualWordPosition() is used from left/rightWordPosition(). For the platforms where the wordbreak is not available, the fallback is going to lead to findNextWordFromIndex() too.. would you mind clarifying what exactly you mean?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.