[Webkit-unassigned] [Bug 110740] Should not return WebTextInputTypeNone for date input element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110740





--- Comment #10 from Seigo Nonaka <nona at chromium.org>  2013-02-26 22:30:22 PST ---
(From update of attachment 190189)
View in context: https://bugs.webkit.org/attachment.cgi?id=190189&action=review

>> Source/WebKit/chromium/ChangeLog:18
>> +        (WebKit::WebViewImpl::textInputInfo):
> 
> The paragraph should be on the function list like:
> 
> * src/WebViewImpl.cpp:
> (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is safe because textInputType returns editable type only for known editable element.

Sure, sorry for my misunderstanding.

>> Source/WebKit/chromium/src/WebViewImpl.cpp:2391
>> +        HTMLElement* element = static_cast<HTMLElement*>(node);
> 
> The code should be:
> 
> if (node->isHTMLElement()) {
>     HTMLElement* element = toHTMLElement(node);
> 
> or
> 
> if (node->isElementNode()) {
>     Element* element = toElement(node);

Sure, done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.