[Webkit-unassigned] [Bug 110925] PDFPlugin: PDF orientation isn't respected when printing or print-previewing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110925


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190400|review?                     |review+
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2013-02-26 19:16:06 PST ---
(From update of attachment 190400)
View in context: https://bugs.webkit.org/attachment.cgi?id=190400&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:812
> +    NSInteger rotation = [pdfPage rotation];
> +    if (rotation == 90 || rotation == 270)
> +        std::swap(cropBox.size.width, cropBox.size.height);

Please add a comment about why this is the right thing to do (which is because we always autorotate). When we looked at this code previously, we both agreed that it was wrong, so it's not at all obvious what's going on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.