[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109061





--- Comment #39 from Brady Eidson <beidson at apple.com>  2013-02-26 11:15:00 PST ---
(In reply to comment #38)
> (In reply to comment #36
> 
> Hi Brady,
> "Favicon" symbol comes from WebCore::IconType enum (defined in Source/WebCore/dom/IconURL.h), and
> >> +const Vector<IconURL>& Document::iconURLs(int iconTypes)
> isn't enum because it's a bitmask of requested icon types.
> This matches IconController::urlsForTypes(int iconTypes) API.

Then please call it iconTypesMask, and no harm in updating the old one also.

r+ with that change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.