[Webkit-unassigned] [Bug 109884] Add CSS Property tracking to FeatureObserver. Creates new histogram for CSS Property usage data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109884





--- Comment #6 from Tony Chang <tony at chromium.org>  2013-02-26 10:10:24 PST ---
(From update of attachment 188471)
View in context: https://bugs.webkit.org/attachment.cgi?id=188471&action=review

This looks much better than what we currently have in CSSParser.cpp (search for histogram).  We should delete the code in CSSParser.cpp to save memory and CPU.

This looks like it has the same problem as the existing code in that it counts the user agent style sheet values, making it hard to tell the actual usage of properties in the user agent style sheet.

> Source/WebCore/page/FeatureObserver.h:126
> +            m_CSSFeatureBits = adoptPtr(new BitVector(numCSSProperties));

Why do we dynamically allocate?  It seems like all pages are going to allocate this unless there's no CSS on the page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.