[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 09:43:54 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109061





--- Comment #38 from Ruslan Abdikeev <aruslan at chromium.org>  2013-02-26 09:46:18 PST ---
(In reply to comment #36)
> (From update of attachment 189837 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189837&action=review
> 
> > Source/WebCore/dom/Document.cpp:4466
> > +const Vector<IconURL>& Document::shortcutIconURLs()
> > +{
> > +    // Include any icons where type = link, rel = "shortcut icon".
> > +    return iconURLs(Favicon);
> > +}
> 
> Where does the "Favicon" symbol come from and...
> 
> > Source/WebCore/dom/Document.cpp:4468
> > +const Vector<IconURL>& Document::iconURLs(int iconTypes)
> 
> ...why is this not an enum?
> 
> This should be an enum

Hi Brady,
"Favicon" symbol comes from WebCore::IconType enum (defined in Source/WebCore/dom/IconURL.h), and
>> +const Vector<IconURL>& Document::iconURLs(int iconTypes)
isn't enum because it's a bitmask of requested icon types.
This matches IconController::urlsForTypes(int iconTypes) API.

Please let me know if anything should be adjusted here.
Otherwise, I'd appreciate if you could approve this patch.

Yours,
-- Ruslan.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list