[Webkit-unassigned] [Bug 110641] WebInspector: Switch hide element shortcut in ElementsPanel to use a selector
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 26 01:05:15 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110641
Pavel Feldman <pfeldman at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #190161|review? |review-
Flag| |
--- Comment #6 from Pavel Feldman <pfeldman at chromium.org> 2013-02-26 01:07:38 PST ---
(From update of attachment 190161)
View in context: https://bugs.webkit.org/attachment.cgi?id=190161&action=review
> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:625
> + this._hideShortcutRule = newRule;
There is an inspector stylesheet per document, you can't store them all in a single variable.
> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:641
> + WebInspector.cssModel.addRule(node.id, hideShortcutSelector, successCallback.bind(this), failureCallback);
I am still not convinced this will only run once per inspector stylesheet. Here is the scenario for you:
1) On a page, press "+" in the styles sidebar to add user-defined style rule.
2) Run _toggleHideShortcut
I suspect that resource will be defined and hence you will not add the new rule.
We might want a test for this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list