[Webkit-unassigned] [Bug 110852] [WIP] [V8] Generate IndexGetter bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110852


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190218|review?                     |review-
               Flag|                            |




--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2013-02-26 01:04:21 PST ---
(From update of attachment 190218)
View in context: https://bugs.webkit.org/attachment.cgi?id=190218&action=review

Thanks for the first patch!

> Source/WebCore/ChangeLog:7
> +

Please describe what this patch is doing.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3259
> +        my @customClassess = (
> +            "V8DOMWindow",
> +            "V8HTMLAppletElement",
> +            "V8HTMLEmbedElement",
> +            "V8HTMLObjectElement",
> +            "V8Storage",
> +            "V8HTMLFormElement",   # Irregular: RefPtr<Node> formElement = form->elements()->item(index);
> +        );

We don't want to hard code class names in code generators. Alternately, you can replace [IndexedGetter] of these IDL files with [V8CustomIndexedGetter] to indicate that they are written in custom bindings. (Then our goal is to replace the [V8CustomIndexedGetter] with [IndexedGetter] as much as possible.)

(There are a lot of hard-coded class names in code generators. We've been trying hard to remove them.)

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:4432
> +    return 1 if $type eq "CSSStyleDeclaration" or $type eq "MediaList" or $type eq "DOMStringList" or $type eq "DOMTokenList" or $type eq "DOMSettableTokenList";

Ditto. We should control whether the binding code is generated by IDL attributes, not by hard-coding something in code generators.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.