[Webkit-unassigned] [Bug 110740] Should not return WebTextInputTypeNone for date input element.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 25 19:56:48 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110740
--- Comment #6 from Seigo Nonaka <nona at chromium.org> 2013-02-25 19:59:12 PST ---
(From update of attachment 190022)
View in context: https://bugs.webkit.org/attachment.cgi?id=190022&action=review
>> Source/WebKit/chromium/ChangeLog:7
>> + because textInputType returns same value as non editable element.
>
> Please put information in https://bugs.webkit.org/show_bug.cgi?id=110740#c0 here.
Done.
>> Source/WebKit/chromium/ChangeLog:10
>> + (WebKit::WebViewImpl::textInputInfo):
>
> Please write why this change is necessary.
Done.
>> Source/WebKit/chromium/src/WebViewImpl.cpp:2391
>> + HTMLElement* element = static_cast<HTMLElement*>(node);
>
> This can cause bad casts. You need to check isHTMLElement.
Done.
>>> Source/WebKit/chromium/src/WebViewImpl.cpp:2393
>>> + return WebTextInputTypeDate;
>>
>> Using WebTextInputTypeDate looks wrong.
>> - We're going to remove it as written in WebTextInputType.h.
>> - This issue affects all of date/time types. WebTextInputTypeDate is only for input[type=date].
>>
>> I think using WebTextInputTypeText is better.
>
> The best solution is to introduce WebTextInputTypeDateTimeField.
We can't use WebTextInputTypeText for other reasons, so let me introduce WebTextInputTypeDateTimeField.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list