[Webkit-unassigned] [Bug 109560] Implement coordinated scrollbar for subframes and overflow:scroll

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109560





--- Comment #56 from Tien-Ren Chen <trchen at chromium.org>  2013-02-25 13:37:32 PST ---
(In reply to comment #55)
> (From update of attachment 189875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189875&action=review
> 
> > Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.h:82
> > +    static WebKit::WebLayer* scrollingWebLayerForScrollableArea(ScrollableArea*);
> > +
> >      void setNonFastScrollableRegion(const Region&);
> >      void setTouchEventTargetRects(const Vector<IntRect>&);
> >      void setWheelEventHandlerCount(unsigned);
> > -    PassOwnPtr<WebKit::WebScrollbarLayer> createScrollbarLayer(Scrollbar*, WebKit::WebLayer* scrollLayer, GraphicsLayer* scrollbarGraphicsLayer, FrameView*);
> >  
> > -    ScrollingCoordinatorPrivate* m_private;
> > +    WebKit::WebScrollbarLayer* addWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation, PassOwnPtr<WebKit::WebScrollbarLayer>);
> > +    WebKit::WebScrollbarLayer* getWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);
> > +    void removeWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);
> 
> I guess this issue existed already, but it seems quite wrong to use WebKit types in WebCore.

Back in the day when the compositor was still in WebKit it was cc::ScrollbayLayerChromium.

It is not the only place we use WebKit types in WebCore though. I think it is not that uncommon to use WebKit types in platform-specific code.

> > Source/WebCore/rendering/RenderLayer.cpp:244
> > +    if (renderer()->frame() && renderer()->frame()->page())
> > +        if (ScrollingCoordinator* scrollingCoordinator = renderer()->frame()->page()->scrollingCoordinator())
> > +            scrollingCoordinator->willDestroyScrollableArea(this);
> 
> This requires braces around the outer if-statement.

Done. Thank you!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.