[Webkit-unassigned] [Bug 110778] Unlock partially decoded images after passing them to the ImageDecodingStore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110778





--- Comment #3 from Min Qin <qinmin at chromium.org>  2013-02-25 12:32:47 PST ---
(From update of attachment 190101)
View in context: https://bugs.webkit.org/attachment.cgi?id=190101&action=review

>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:145
>> +        cachedDecoder->lockFrameBuffers();
> 
> You want to call this in ImageDecodingStore::lockCache() such that if lockFrameBuffers fails then a new decoder is created.

The lockFrameBuffers() will not fail here. We reach here only if ImageDecodingStore::lockCache() succeeds. Since that call will lock the DiscardablePixelRef, so lockFrameBuffers() will not fail. It only increments the pixelref lock count by 1.
Maybe I should add a comment to mention that the FrameBuffer is already locked when this gets called, so we are safe to use the same decoder.

>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:150
>> +            cachedDecoder->unlockFrameBuffers();
> 
> Move this to ImageDecodingStore as well.

same reason

>> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:178
>> +        decoder->unlockFrameBuffers();
> 
> Move this to ImageDecodingStore.

same reason, we are safe to call this here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.