[Webkit-unassigned] [Bug 108678] [BlackBerry]Adjust fatfinger detection rect size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 25 07:47:18 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108678





--- Comment #16 from Tiancheng Jiang <tijiang at rim.com>  2013-02-25 07:49:41 PST ---
Yes it should be getAdjustedPaddings(), a mistake when prepare the upstream patch. Thanks Alberto!

(In reply to comment #15)
> >  void FatFingers::getNodesFromRect(Document* document, const IntPoint& contentPos, ListHashSet<RefPtr<Node> >& intersectedNodes)
> >  {
> >      unsigned topPadding, rightPadding, bottomPadding, leftPadding;
> > -    getPaddings(topPadding, rightPadding, bottomPadding, leftPadding);
> > +    IntPoint contentViewportPos = m_webPage->mapFromContentsToViewport(m_contentPos);
> > +    // Do not allow fat fingers detect anything not visible(ie outside of the viewport)
> > +    adjustPaddings(contentViewportPos, topPadding, rightPadding, bottomPadding, leftPadding);
> 
> Is this correct? adjustPaddings() doesn't seem to be defined anywhere,
> shouldn't it be getAdjustedPaddings() instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list