[Webkit-unassigned] [Bug 110641] WebInspector: Switch hide element shortcut in ElementsPanel to use a selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110641


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189824|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2013-02-24 22:39:01 PST ---
(From update of attachment 189824)
View in context: https://bugs.webkit.org/attachment.cgi?id=189824&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:491
> +                this._addHideShortcutRuleToInspectorStyleSheet(node.id, hideShortcutSelector);

You only need to do this once.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:634
> +            if (!resource)

Resource may exist due to user's add rule action.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:638
> +        WebInspector.cssModel.getViaInspectorResourceForRule(this._hideRule || {}, resourceCallback.bind(this));

We need to move this into model via creating addInspectorRule method that receives both selector and rule body.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.