[Webkit-unassigned] [Bug 103644] [GTK] Split GtkAuthenticationDialog in two widgets
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 24 06:43:02 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=103644
--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com> 2013-02-24 06:45:24 PST ---
Attachment 189975 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/platform/gtk/GtkAuthenticationDialog.cpp', u'Source/WebCore/platform/gtk/GtkAuthenticationDialog.h', u'Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp', u'Source/WebCore/platform/gtk/WebKitAuthenticationWidget.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/GNUmakefile.am', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/po/ChangeLog', u'Source/WebKit/gtk/po/POTFILES.in', u'Source/WebKit/gtk/webkit/webkitauthenticationdialog.cpp', u'Source/WebKit/gtk/webkit/webkitauthenticationdialog.h', u'Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h', u'Source/autotools/Versions.m4', u'Tools/ChangeLog', u'Tools/gtk/generate-gtkdoc']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.h"
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:166: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:170: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:171: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:176: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:179: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp:180: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 6 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list