[Webkit-unassigned] [Bug 106594] [chromium] Register newly-created layers for animation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 10:15:48 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=106594


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189777|review?                     |review+
               Flag|                            |




--- Comment #11 from James Robinson <jamesr at chromium.org>  2013-02-22 10:18:11 PST ---
(From update of attachment 189777)
View in context: https://bugs.webkit.org/attachment.cgi?id=189777&action=review

R=me - one change suggested before landing. You don't need to ask me for another review after moving that, just ask any friendly neighborhood WebKit committer to help you out.  Thanks for the iterations and explanations!

> Source/WebKit/chromium/src/WebViewImpl.cpp:212
> +class GraphicsLayerFactoryChromium : public GraphicsLayerFactory {

WebViewImpl.cpp is kind of gigantic, so I would consider moving this class out to its own header/cpp just to cut down on churn.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list