[Webkit-unassigned] [Bug 110416] [CMake] VS 2008 fails to link WebCore.lib because it is too large

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 08:50:06 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=110416





--- Comment #7 from Mark Salisbury <mark.salisbury at hp.com>  2013-02-22 08:52:29 PST ---
Q1: Yes, unfortunately.
Q2: I don't think we want to reserve space for all libraries globally, just webcore as it's the big beast.

I initially wanted to only change Source/WebCore/PlatformWinCE.cmake, but the pattern for all other libraries is to create a variable named <library name>_LINK_FLAGS, so that the common cmake file could set link flags but at the same time allow platform specific link flags to be specified.

I think the other reason that I had to add code to WebCore/CMakeLists.txt to add the link flags is that the link flags have to be added after the "add_library" command but the platform file must be included before the "add_library" command.

I could make my changes smaller by not providing support for setting link flags if building webcore as SHARED_CORE (dll).  I did some experimenting with building webcore as a dll and found other problems that prevented building webcore as a .dll (believe those were dependencies on webkit and lack of exports).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list