[Webkit-unassigned] [Bug 110431] INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110431





--- Comment #10 from Kent Tamura (ooo until Mar 15) <tkent at chromium.org>  2013-02-22 04:08:08 PST ---
(From update of attachment 189686)
View in context: https://bugs.webkit.org/attachment.cgi?id=189686&action=review

>>> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:376
>>> +    const AtomicString pattern = m_dateTimeEditElement->getAttribute(HTMLNames::patternAttr);
>> 
>> getAttribute should be fastGetAttribute because it is not a "style" attribute.
>> You can remove HTMLNames::.
> 
> Changed to fastGetAttribute.
> HTMLNames:: is necessary here - or should I add "using namespace HTMLNames" at the top?

We usually declare "using namespace foo" in an implementation file, and omit the namespace prefix, except std::.  This is not mandatory.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.