[Webkit-unassigned] [Bug 105126] Flexbox should ignore firstLetter pseudo element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105126





--- Comment #12 from huangxueqing <huangxueqing at baidu.com>  2013-02-22 02:29:52 PST ---
(In reply to comment #10)
> (From update of attachment 179648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179648&action=review
> 
> >>> Source/WebCore/rendering/RenderBlock.cpp:6466
> >>> +        return;
> >> 
> >> This looks funny. Do we create the first letter renderer?
> > 
> > This code just prevent RenderBlock update its first text child. No, the first letter renderer would not be created. The first letter renderer as the first text child's new parent used to update RenderText's first letter info.
> 
> I think this check should go in findFirstLetterBlock.  Why do we check both if both |this| is a flexible box and if its parent is a flexible box?

I moved this check in |findFirstLetterBlock|. RenderObject maybe apply first-letter from own style or inhretied from parent. For example:
<style>
   div::first-letter {color: red}
</style>
<div>
    <P>
</div>
"div" apply first-letter from own style while "p" inherited from "div".

In addition, the case marked as failling in Chromium TestExpectations apply first-letter psuedo-element but form controls render as flexbox, see
WebCore/css/html.css:
input[type="date"|"datetime"|"datatime-local"|"month"|"time"|"week"] {
    ... ...
    display: -webkit-inline-flex;
    ... ...
}
The testcase fast/forms/week/week-appearance-pseudo-elements.html apply first-letter as:
<style type="text/css">
... ...
.first-letter:first-letter { color: green; font-size: 200%; }
</style>
<ul>
    ... ...
    <li><input type="week" value="1982-W25" class="first-letter"></li>
</ul>

This change make "color: green; font-size: 200%;" did not apply week control anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.