[Webkit-unassigned] [Bug 110431] INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 21 23:05:47 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=110431
Kent Tamura (ooo until Mar 15) <tkent at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #189686|review? |review-
Flag| |
--- Comment #7 from Kent Tamura (ooo until Mar 15) <tkent at chromium.org> 2013-02-21 23:08:10 PST ---
(From update of attachment 189686)
View in context: https://bugs.webkit.org/attachment.cgi?id=189686&action=review
> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:376
> + const AtomicString pattern = m_dateTimeEditElement->getAttribute(HTMLNames::patternAttr);
getAttribute should be fastGetAttribute because it is not a "style" attribute.
You can remove HTMLNames::.
> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:377
> + if (!pattern.isNull() && !pattern.isEmpty())
isNull() check is unnecessary. isEmpty means "null or 0-length"
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list