[Webkit-unassigned] [Bug 110127] [GTK][EFL] HEAD requests changed to GET after 303 redirection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110127





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2013-02-21 10:13:02 PST ---
(From update of attachment 189532)
View in context: https://bugs.webkit.org/attachment.cgi?id=189532&action=review

In general, this looks good to me. I've a few nits about the test.

> LayoutTests/http/tests/xmlhttprequest/head-redirection-expected.txt:1
> +Test redirection codes with HEAD.

I think you should include a longer description here. See LayoutTests/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt for an example.

There are also some issues with style in the test code.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:28
> +        if(hasError) {

Missing a space here.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:31
> +        }
> +        else {

should be 
} else {

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:32
> +            var reqMethod = xhr.getResponseHeader('REQMETHOD');

Normally in WebKit we don't abbreviate variable names.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:37
> +        if(++testIndex<tests.length) {

Missing a space here as well.

> LayoutTests/http/tests/xmlhttprequest/head-redirection.html:40
> +        }
> +        else if (window.testRunner) {

} else if {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.