[Webkit-unassigned] [Bug 106594] [chromium] Register newly-created layers for animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106594





--- Comment #8 from Ali Juma <ajuma at chromium.org>  2013-02-21 08:25:21 PST ---
(In reply to comment #7)
> (From update of attachment 189364 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189364&action=review
> 
> > Source/WebKit/chromium/src/ChromeClientImpl.cpp:120
> > +    GraphicsLayerFactoryChromium(WebKit::WebViewImpl* webView)
> 
> explicit
> 
> > Source/WebKit/chromium/src/ChromeClientImpl.cpp:136
> > +    // GraphicsLayerFactoryChromium's lifetime is bounded by that of its owning
> > +    // ChromeClientImpl, whose own lifetime is bounded by that of m_webView.
> 
> Hmm - you'll have to remind me.  Why doesn't the WebViewImpl just own this object directly?

WebViewImpl could own this directly. As I understand it, the only reason it's currently owned by ChromeClientImpl is that this seemed to be a logical place for it since ChromeClientImpl defines a ::graphicsLayerFactory method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.