[Webkit-unassigned] [Bug 100754] Faster sorting of numeric arrays

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100754


Yong Li <yoli at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #188192|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #39 from Yong Li <yoli at rim.com>  2013-02-21 06:57:21 PST ---
(From update of attachment 188192)
View in context: https://bugs.webkit.org/attachment.cgi?id=188192&action=review

LGTM basically. Changes suggested by previous reviewers are addressed. But see my comment.

> Source/JavaScriptCore/bytecode/ComparatorKind.h:35
> +enum ComparatorKind {
> +    CustomComparator,
> +    NumericAscendingComparator,
> +    NumericDescendingComparator
> +};

This enum will be folded into a 2-bit bit-field. It would be nice to add some comments or compile time assert just in case someone inserts more enum values but doesn't check the bit-field accordingly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.