[Webkit-unassigned] [Bug 110193] OpenCL implementation of FEMerge filter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110193





--- Comment #7 from Zoltan Herczeg <zherczeg at webkit.org>  2013-02-20 06:48:30 PST ---
(From update of attachment 189307)
View in context: https://bugs.webkit.org/attachment.cgi?id=189307&action=review

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:39
> +const sampler_t sampler = CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;
> +__kernel void copy(__write_only image2d_t destination, __read_only image2d_t source, int x, int y)

Newline after the sampler.

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:77
> +inline void FilterContextOpenCL::applyFEMergeCopy(OpenCLHandle destination, IntSize destinationSize, OpenCLHandle source, IntPoint &relativeSourcePoint)

The & sign should be pert of the type:
IntPoint& relativeSourcePoint
IntSize& destinationSize

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEMerge.cpp:87
> +inline void FilterContextOpenCL::applyFEMerge(OpenCLHandle destination, OpenCLHandle previousDestination, OpenCLHandle sourceA, OpenCLHandle sourceB, IntSize destinationSize, IntPoint &relativeSourcePointA, IntPoint &relativeSourcePointB)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.